Async actions don't return a proper promise

I’m wondering why async actions don’t return a proper promise:

actions: {
    waitFor3sec: async () => {
      await new Promise(resolve => setTimeout(resolve, 3000));
      return "done";
    }
  }

// ...
console.log("now");
await overmind.actions.waitFor3sec(); // <- this seems to be sync
console.log("after 3 seconds");

Complete example here: https://codesandbox.io/s/6loqylpk3k

They also don’t seem to return the returned value ('done' in this case).

We are currently using MobxStateTree but thinking about moving to Overmind.

[christianalfoni]

Hi guys! 😃

That the returned promise form an action is not “awaitable” must be a bug. Thanks for the suggested fix @JM-Mendez! I will look into that and make it fit nicely in 😃

The reason actions does not return a value is really to avoid patterns where you decouple your logic into multiple actions. When you get into the need of composing logic we encourage you to look at the functional API. That will allow you to run actions in order, map in new values etc. https://www.overmindjs.org/guides/intermediate/04_goingfunctional?view=react&typescript=false

An additional benefit here is that Overmind will also understand what is “coherent” logic, allowing you to debug it better, as seen in this devtools video: https://www.overmindjs.org/videos/devtools-introduction?view=react&typescript=false

But guys, this is awesome, thanks so much for discussing and sharing. Stay tuned for bug fix 😃

[luisherranz]

Working perfectly now in @next: https://codesandbox.io/s/r073jp1jl4

Both actions and onInitialize 😃