[BUG] Throwing from async actions and effects causes uncaught errors (even when those are explicitly caught) - React

Hello,

minimal codesandbox example here - https://codesandbox.io/s/overmind-example-toloe?file=/src/components/App.js . The core of the issue is as follows:

// in component
useEffect(() => {
    // the error is correctly caught here but also propagates as unhandled
    new Promise((resolve, reject) => {
      // if I throw directly from here I'll only get the console log from catch clause
      // throw new Error('uncomment to see correct behaviour')
      // if thrown from action I'll get the react overlay
      actions.exampleAction().catch(e => reject(e));
    }).catch(e => console.log(e));
  }, [actions]);

// overmind/index.js
export const config = {
  actions: {
    // if the action is sync all is well
    exampleAction: async ({ state, effects }) => {
      throw new Error("hello");
      // same behaviour when throwing from effects, whether awaited or not
      // effects.test();
    }
  },
  effects: {
    // when sync all is good, adding async keyword seems to break this ?
    test: async () => {
      throw new Error("hello");
    }
  }
};

This might be related to https://github.com/cerebral/overmind/issues/318 but the behaviour is slightly different - the error actually gets caught by the catch clause, but somehow it also propagates as unhandled. I’m also not sure if this may be related to React, the original issue was for Vue.

Thanks for the reply and for the library as well. Cheers.

[christianalfoni]

Thanks a bunch for the example! Will look at this for next release! 😄

[christianalfoni]

Closing this for now as it will be part of next release 😄