Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Set overmind as peerDependency in overmind-react and other packages

See original GitHub issue

Because we cannot use overmind-react without overmind, we can set overmind as peerDependency in overmind-react and other same packages (overmind-angular, overmind-vue)

Issue Analytics

State:
Created 5 years ago
Comments:9 (7 by maintainers)

Top GitHub Comments

1reaction

luisherranzcommented, Feb 22, 2019

It’s not problematic in most cases, it’s just the way it’s usually done in npm.

The only problem I see is a possible conflict in the case somebody wants to use a fork/alternative to the main overmind package (for a bug fix or added feature which is not in the official one). They would end up with an overmind@next from overmind-react and their own overmind version installed from GitHub or with a different name. They can solve it forking overmind-react as well so it’s not a big deal.

1reaction

luisherranzcommented, Feb 10, 2019

I was about to open this issue as well. With a peer dependency the user can choose what overmind version to install. It may not be overmind: next like it is “hardcoded” right now.

Also, I don’t see a problem with npm install overmind overmind-react because it’s already a common pattern with many other tools: react and react-dom, mobx and mobx-react, redux and react-redux and so on…