question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Allow Overlay above SlidePanel

See original GitHub issue

Issue Description

CareAware Connect would like to use LoadingOverlay above all parts of SlidePanel, including the panel part. This is currently not possible without manually overriding the z-index of the overlay.

This is because Overlay has a z-index of 100 and SlidePanel’s panel has a z-index of 500.

I’d like to propose introducing a prop to dictate whether Overlay has a larger z-index. Considerations will need to be made for whether Overlay covers modals in this scenario.

Issue Type

  • New Feature
  • Enhancement
  • Bug
  • Other

Expected Behavior

Overlay covers both single and multi-panel SlidePanel mode

Current Behavior

Overlay is hidden in single slide panel mode

Steps to Reproduce

N/A

Environment

  • Component Version:
  • Browser Name and Version: Chrome 61.0.3163.100 (Official Build) (64-bit)
  • Operating System and version (desktop or mobile): macOS 10.12.6 (16G29)

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
neilpfeiffercommented, Jul 24, 2018

Discussed with @dkasper-was-taken as to technical issues. If a overlay is presented from a SlidePanel, or any container with it’s position set by transform, the fullscreen overlay does not work as intended (loses context of original document positioning).

As a generally concept, we probably want to avoid opening up the option to add zIndex as prop and leave up to consumers without a central governing strategy, which would create an accidental and uncontrolled “king-of-the-hill” situation when multiple higher-order components are combined onto one page or within one application.

Possible option that solves for both concerns is to add a new type of fullscreen overlay that is portaled and at a z-index of 9999 or similar. For current passivity, we could keep the isRelativeToContainer prop since it is widely used (eventually deprecate & remove), and introduce a new prop, something like relativeTo: container, fullscreen, portal (final names pending) keeping the first two as-is with current behavior and z-index and introducing the third type as new (portaled version will be similar to AbstractModal).

1reaction
bjankordcommented, Jul 12, 2018

@neilpfeiffer Any thoughts on making the overlay always appear over everything.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to keep Panel overlay above fixed footer on Jquery Mobile
It basically serves to create a sliding panel. My footer however is applied with fixed with "data-position="fixed".
Read more >
Slide-out Panels, Modal Windows, and Overlays
This passive control allows the user to drill down to the desired level without the need to close each panel via the cancel...
Read more >
sliding_up_panel | Flutter Package - Pub.dev
A draggable Flutter widget that makes implementing a SlidingUpPanel much easier!
Read more >
SMOOTH Slide Panel and Auto Zoom / Timesaving EFFECTS ...
AUTO ZOOM The auto zoom effect allows you to quickly set up a zoom ... or just want to say thanks, click the...
Read more >
Android Sliding Up Panel - GitHub
If you would like to hide the shadow above the sliding panel, set shadowHeight attribute to 0. Use setEnabled(false) to completely disable the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found