Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create consumer theme for form input

See original GitHub issue

Issue Description

To match consumer UX, we want to enable the theming of terra input. Here is a screenshot of the current component: screen shot 2017-08-28 at 9 27 53 am

Evaluate if we will solve this issue as well https://github.com/cerner/terra-core/issues/755

Issue Type

New Feature
Enhancement
Bug
Other

Expected Behavior

CSS custom properties are added to enable the theming of the <Input /> component to match consumer UX visuals.

Issue Analytics

State:
Created 6 years ago
Comments:11 (11 by maintainers)

Top GitHub Comments

1reaction

StephenEssercommented, Aug 29, 2017

Using the not selector is a good indication of poor encapsulation. My vote is for the second approach Alex suggested. The Control should either not consume the base input or the base input should contain the bare minimum styles that apply to every input and do not cause conflicts. It feels awkward the base Input.scss immediately overrides declared styles to satisfy radio / checkbox and then then Control.scss also adds its’ own styles.

There’s already some conflicting styles in Input.scss from Control.scss https://github.com/cerner/terra-core/blob/master/packages/terra-form/src/Control.scss#L5 https://github.com/cerner/terra-core/blob/master/packages/terra-form/src/Input.scss#L15

My opinion is that radio / checkbox specific theme-able styles should be encapsulated in Control.scss, or Radio.scss / Checkbox.scss respectively

0reactions

neilpfeiffercommented, Feb 6, 2018

OCS input has been created and will be resolved by current work on this new issue #1207