[terra-form-select] Array of numbers for MultiSelect produces proptype warnings

Bug Report

Description

Previously on terra-form-select 5.25.0, given a multiple variant (MultiSelect or TagSelect), we could pass a list of numbers for the value prop:

Select.jsx:100 SelectField.jsx:102

<Select
  variant={'multiple'}
  value={[12, 34, 56, 78]}
>
  {...}
</Select>

When the large refactor happened for terra-form-select 5.26.0, the proptype validation requires value to be an array of strings. MultiSelect.jsx:93

Steps to Reproduce

Create a Select component with a ‘multiple’ variant Set the value to an array of numbers Receive proptype validation warnings

Additional Context / Screenshots

Expected Behavior

This code would not produce a proptype error.

Possible Solution

Update MultiSelect.jsx:93 to accept an array of numbers or strings

Environment

• Component Name and Version: terra-form-select@5.26.0+
• Browser Name and Version: Latest Chrome
• Node/npm Version: Node 8, npm 5
• Operating System and version (desktop or mobile): Any

@ Mentions

@dev-cprice

[bjankord]

My preference is let’s allow the previous behavior (let Single Selection variants to accept an array) to keep the functionality passive. When we do the next MVB for this package, we can reconsider how we want that to work.

[StephenEsser]

This was not a bug prior to the changes made in v5.25.0. The Select had a consistent PropType expectation for all variants.

This worked both ways, the multiple Select variant could also accept a string as a defaultValue.

This avoided a complex prop driven custom PropType validator and allowed consistent behavior and expectations between all variants.

As the Select is being broken out into individual resources I do think the more strict PropTypes are appropriate. I do not think the <SearchSelect /> should accept an array. The issue is being passive with the original <Select /> API.