Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug when zooming timeline too fast

See original GitHub issue

Steps to reproduce:

Load https://cesiumjs.org/Cesium/Apps/HelloWorld.html
Put cursor over timeline and give it one fast scroll (two fingers on touchpad)
Try zooming a few more times and it should not zoom anymore

I think the bug is in the code below. It goes away if you make timelineWheelDelta constnat, but this decouples zooming speed from scrolling speed.

function createMouseWheelCallback(timeline) {
        return function(e) {
            var dy = e.wheelDeltaY || e.wheelDelta || (-e.detail);
            timelineWheelDelta = Math.max(Math.min(Math.abs(dy), timelineWheelDelta), 1);
            dy /= timelineWheelDelta;
            timeline.zoomFrom(Math.pow(1.05, -dy));
        };
    }

Issue Analytics

State:
Created 7 years ago
Comments:12 (7 by maintainers)

Top GitHub Comments

1reaction

nikakhovcommented, Nov 9, 2016

I’m looking into this.

0reactions

nikakhovcommented, Nov 29, 2016

I created a pull request:

https://github.com/AnalyticalGraphicsInc/cesium/pull/4693

However, right now this fix can produce “undefined” labels in the tick marks if you zoom too far. Perhaps, it needs to be combined with min and max zoom limits.