Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update `IndexDatatype.createTypedArray` to create Uint8Arrays

See original GitHub issue

Currently IndexDatatype.createTypedArray only outputs Uint16Array and Uint32Array. This caused a bug in #10344 because it returned a Uint16Array for uint8 indices, which was too big for the getBufferData function. The fix itself is easy but it causes a lot of unit tests to break, which will take more time to fix.

Once this function is changed to return Uint8Array, the manual check in buildDrawCommands can be removed to accommodate this.

Issue Analytics

State:
Created a year ago
Comments:9 (3 by maintainers)

Top GitHub Comments

1reaction

rravula77commented, Dec 2, 2022

Hello, my team and I would like to work on the issue

1reaction

j9liucommented, May 10, 2022

Hi @malitherl,

Thanks for your interest in contributing! For smaller issues (like those labeled “good first issue”), there’s no need to ask for permission. It’s customary to comment on the issue or start a thread on our forum for larger features or code changes, but this one shouldn’t be too sizeable. You can work on the issue and open a pull request for review when ready.

If you have any questions, you can comment on the issue or on the PR itself if it’s far enough along to open. There’s also a lot of standard documentation in the Contributors folder if you need guidance.

Top Results From Across the Web

Uint8Array - JavaScript - MDN Web Docs

Chrome Edge Uint8Array Full support. Chrome7. Toggle history Full support. Edge12... Uint8Array() constructor Full support. Chrome7. Toggle history Full support. Edge12... Constructor without parameters Full support....