Update `IndexDatatype.createTypedArray` to create Uint8Arrays
See original GitHub issueCurrently IndexDatatype.createTypedArray
only outputs Uint16Array
and Uint32Array
. This caused a bug in #10344 because it returned a Uint16Array
for uint8 indices, which was too big for the getBufferData
function. The fix itself is easy but it causes a lot of unit tests to break, which will take more time to fix.
Once this function is changed to return Uint8Array
, the manual check in buildDrawCommands
can be removed to accommodate this.
Issue Analytics
- State:
- Created a year ago
- Comments:9 (3 by maintainers)
Top Results From Across the Web
Uint8Array - JavaScript - MDN Web Docs
Chrome Edge
Uint8Array Full support. Chrome7. Toggle history Full support. Edge12...
Uint8Array() constructor Full support. Chrome7. Toggle history Full support. Edge12...
Constructor without parameters Full support....
Read more >IndexDatatype - Cesium Documentation
Creates a typed array from a source array buffer. The resulting typed array will store indices, using either or Uint32Array depending on the...
Read more >Uint8Array to string in Javascript - Stack Overflow
call(uint8array, 'utf8')” to avoid creating a new buffer instance. – user11390576. Nov 23, 2020 at 8:49. 2.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Hello, my team and I would like to work on the issue
Hi @malitherl,
Thanks for your interest in contributing! For smaller issues (like those labeled “good first issue”), there’s no need to ask for permission. It’s customary to comment on the issue or start a thread on our forum for larger features or code changes, but this one shouldn’t be too sizeable. You can work on the issue and open a pull request for review when ready.
If you have any questions, you can comment on the issue or on the PR itself if it’s far enough along to open. There’s also a lot of standard documentation in the Contributors folder if you need guidance.