Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Template String Conversion into HTML Nodes drops <style> Nodes
See original GitHub issueThis is due to DOMParser.parseFromString(template) puts any <style> tags into the <head> of the returned document. When Reef’s internal stringToHTML function returns doc.body the markup in the head is lost.
Test case: https://codepen.io/semmel-semmel/pen/LYYLPym
When clicking the button reefApp.setData will update the custom element’s dom, however it looses the inline styles inside the web component, because stringToHTML drops all <style> nodes. Thus text looses it’s colour.
A fixed in stringToHTML could be
// ...
// If DOMParser is supported, use it
if (support) {
var parser = new DOMParser();
var doc = parser.parseFromString(str, 'text/html');
doc.body.prepend(...doc.head.childNodes); // <--- Added this line
return doc.body;
}
//...
Does this make sense?
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Ah yep… here we go: https://codepen.io/cferdinandi/pen/rNNwMeE
I see it now.
@cferdinandi
No need to apologise, Open Source projects should be fun first - obligations last! 😄