Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Global Calculated Coordinates/Waypoints] Remove old code

See original GitHub issue

After switching to new global waypoints is done, old local coordinate codebase can be removed (excluding parts which are needed e.g. to read old Personal Notes and to migrate).

This should not be done before the new implementation was out in the field for a while to prove it is stable.

Following classes/files are candidates for removal:

cgeo.geocaching.ui.EditButton
cgeo.geocaching.ui.CalculateButton
cgeo.geocaching.ui.CalculatorVariable
cgeo.geocaching.models.CalcState
cgeo.geocaching.ui.dialog.CoordinatesCalculateDialog
coordinatescalculate_dialog.xml (both layout variants)
coordinates_calculate.xml
coordinate_equation.xml
strings.xml: values marked with "legacy"

Issue Analytics

State:
Created 2 years ago
Comments:12 (12 by maintainers)

Top GitHub Comments

1reaction

eddiemuccommented, May 30, 2022

I looked at the code a bit more deeply. I think it should be possible to extract the core parts of F-PLAIN coordinate scanning and parse it as “plain” new calculated coordinates behind thje scenes without having to keep the whole class structure.

So I am positive we can keep scanning the then-legacy F-PLAIN coordinates too. No need for an announcement then.

1reaction

murggelcommented, May 28, 2022

Probably we can make an announcement, that the migration of the F-Plain format will be removed in one of the next versions, so those who have still the format in some PN can do the migration before it will be removed.

Top Results From Across the Web

[Global Calculated Coordinates/Waypoints] Migrate local calculated ...

In order to replace the local calculated waypoints with global calculated waypoints, existing waypoints must be migrated to the new format.

Waypoint Calculator - c:geo User Guide

c:geo offers a calculator for waypoints, which allows to make use of variables and formulas to calculate coordinates based on the result.

Exceed 23 waypoint per request limit on Google Directions ...

One of the customers requirements is that he be able to calculate routes with at least 30 ( preferably more ) waypoints. According...

Version more 4

Enabled the delete key to delete individual waypoints from the child ... "Database=>Global replace" now supports escaping of characters via the chr() ...

Getting directions through the Directions API

The API returns the most efficient routes when calculating directions. ... Plus codes must be formatted as a global code or a compound...