Offline-Log-filter does not work for "Schneller Offline log"

Describe your problem!

While working on #11430 I tried also the OfflineLog-Filter. And it did not worked for me. The caches with “Schneller Offline log” were not shown, when I use the filter-option “Is present”

Or is that the expected behaviour - means “description is (not) present” and not “offline log is (not) present”?

How to reproduce?

Store a cache in a list Create an offline log with empty description for that cache. Create Offline-log-filter with “Is present”-option. Select that filter for the list.

Actual result after these steps?

Cache is not shown in the filtered list

Expected result after these steps?

Cache should be shown in the filtered list

Reproducible

Yes

c:geo Version

2021.07.30-RC and Nightly

System information

## System information

c:geo version: 2021.08.08-3c37a42 developer build

Device:
-------
- Device type: sdk_gphone_x86_arm (sdk_gphone_x86_arm, google)
- Available processors: 4
- Android version: 11
- Android build: sdk_gphone_x86_arm-userdebug 11 RSR1.201013.001 6903271 dev-keys
- Screen resolution: 1080x2088px (392x735dp)
- Sailfish OS detected: false
- Google Play services: enabled - 20.18.17 (040700-311416286)
- HW acceleration: enabled (default state)

Sensor and location:
-------
- Low power mode: inactive
- Compass capabilities: yes
- Rotation vector sensor: present
- Orientation sensor: present
- Magnetometer & Accelerometer sensor: present
- Direction sensor used: rotation vector

Program settings:
-------
- Settings: v8, Count:118
- Set language: en
- System date format: M/d/yy
- Time zone: GMT
- Debug mode active: no
- Last backup: never
- Routing mode: Bike
- Live map mode: false
- OSM multi-threading: false / threads: 1
- Map: OpenStreetMap.org
  - Id: cgeo.geocaching.maps.mapsforge.MapsforgeMapProvider$OsmMapSource
  - Atts: © OpenStreetMap DE, map data OpenStreetMap contributors
  - Theme: none

Filters:
-------
- Hide waypoints: -
- LIVE: asf ([asf:inconclusive=false:advanced=true]AND(type:WEBCAM;difficulty_terrain:d=-:d=-:t=-:t=-;status))
- OFFLINE: None ([:inconclusive=false:advanced=false])

Services:
-------
- Geocaching sites enabled:
   geocaching.com: Logged in (Login OK) / BASIC
- Geocaching.com date format: dd.MM.yyyy
- Routing: internal / BRouter installed: false
- Installed c:geo plugins:  none

Permissions & paths:
-------
- Fine location permission: granted
- Write external storage permission: granted
- System internal c:geo dir: /data/user/0/cgeo.geocaching (4.8 GB free) v2 internal isDir(6 entries)
- Legacy User storage c:geo dir: /data/user/0/cgeo.geocaching (4.8 GB free) v2 internal isDir(6 entries)
- Geocache data: /storage/emulated/0/Android/data/cgeo.geocaching/files/GeocacheData (4.8 GB free) v2 external non-removable isDir(8 entries)
- Internal theme sync (is turned off): /data/user/0/cgeo.geocaching/MapThemeData (4.8 GB free) v2 internal isDir(0 entries)
- Public Folders: #11
  - BASE: /cgeo (User-Defined)[/cgeo[DOCUMENT#0:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo, Av:true, files:>=3, dirs:>=8, totalFileSize:>=1.7 KB, free space: 4.8 GB, files on device: 393216)
  - OFFLINE_MAPS: /cgeo/maps (Default)[/cgeo/maps[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/maps]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Fmaps, Av:true, files:0, dirs:1, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - OFFLINE_MAP_THEMES: /cgeo/maps/_themes (Default)[/cgeo/maps/_themes[PERSISTABLE_FOLDER(OFFLINE_MAPS)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/maps/_themes]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Fmaps%2F_themes, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - LOGFILES: /cgeo/logfiles (Default)[/cgeo/logfiles[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/logfiles]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Flogfiles, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - GPX: /cgeo/gpx (Default)[/cgeo/gpx[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/gpx]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Fgpx, Av:true, files:3, dirs:0, totalFileSize:1.7 KB, free space: 4.8 GB, files on device: 393216)
  - BACKUP: /cgeo/backup (Default)[/cgeo/backup[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/backup]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Fbackup, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - FIELD_NOTES: /cgeo/field-notes (Default)[/cgeo/field-notes[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/field-notes]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Ffield-notes, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - SPOILER_IMAGES: /cgeo/GeocachePhotos (Default)[/cgeo/GeocachePhotos[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/GeocachePhotos]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2FGeocachePhotos, Av:true, files:1, dirs:3, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - ROUTING_BASE: /cgeo/routing (Default)[/cgeo/routing[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/routing]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Frouting, Av:true, files:7, dirs:1, totalFileSize:81.2 KB, free space: 4.8 GB, files on device: 393216)
  - ROUTING_TILES: /cgeo/routing/segments4 (Default)[/cgeo/routing/segments4[PERSISTABLE_FOLDER(ROUTING_BASE)#1:p-content://com.android.externalstorage.documents/tree/primary%3Acgeo::/routing/segments4]] (Uri: content://com.android.externalstorage.documents/tree/primary%3Acgeo/document/primary%3Acgeo%2Frouting%2Fsegments4, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 4.8 GB, files on device: 393216)
  - TEST_FOLDER: [Legacy]/data/user/0/cgeo.geocaching/files/unittest (Default)[/data/user/0/cgeo.geocaching/files/unittest[FILE#1:p-file:///data/user/0/cgeo.geocaching/files::/unittest]] (Uri: file:///data/user/0/cgeo.geocaching/files/unittest, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 4.8 GB, files on device: -1)
- Map render theme path: 
- PersistedDocumentUris: #1
- TRACK: null
- Persisted Uri Permissions: #1
  - content://com.android.externalstorage.documents/tree/primary%3Acgeo (Jun 15, 9:41 PM):RW
- Database: /data/user/0/cgeo.geocaching/databases/data (v96, Size:292.0 KB) on system internal storage

--- End of system information ---

Additional Information

I guess, it’s because the log does not contain any description (empty text). Will this be treated as “not present”?

And for my use-case I should use only “has offline log” in the status filter?

Or is that the expected behaviour - means “description is (not) present”? But then - with the changes of #11430 - there is no possibility to filter for empty e.g. “didn’t find”, correct?

[eddiemuc]

Do we have a follow up issue for adapting the “Offline log” filter with “offline log is present” (current implementation for “is present” considers only the description, I can’t filter for caches with empty offline logs)?

Or this should be considered in #11430?

I created #11518 for this

[fm-sys]

I can’t filter for caches with empty offline logs)? Or this should be considered in #11430?

With #11430 we will have two status filters, “offline log” and “found offline”. So the situation will be as currently, except that the quick settings will trigger the new “found offline” filter…

BTW, this would even allow filter constellations like “has offline log” but “log text is not present”. So users can filter for all logs without log text, which might be a cool addition for someone…