Unneeded file copy dialog on clean install

Describe your problem!

While playing testing the c:geo installation on various “out-of-the-box” (wiped) emulators I noticed a wrong behavior. After selecting a base folder the dialog for copy/move from previous base folder is shown while there is no previous base folder in that case.

How to reproduce?

• Wipe API30 emulator
• Build and install c:geo on it
• Run the wizard
• Provide permissions as requested
• When selecting the base folder, create a new folder (my example: cgeo123) and select it as base folder
• Confirm allowing c:geo to access this folder

Actual result after these steps?

The “change folder base” dialog is shown:

Expected result after these steps?

This dialog should be skipped as there is no change but the base folder was assigned for the first time.

Reproducible

Yes

c:geo Version

Current master 11.10.2021

System information

Android 11 (API30) emulator
Pixel 4

Additional Information

No response

[Lineflyer]

Maybe easiest solution is to skip the copy/move dialog in general if source folder does not contain any files/folders.

Folders are there, but no files. So the condition should probably be to skip the dialog if no files are contained.

[eddiemuc]

My assumption: Reason seems to be, that on time of install the (preliminary) base folder is considered to be /user/data/0/cgeo.geocaching/files/public/BASE as this seems to be the last resort fallback already created before the SAF dialog is triggered.

Assumption is correct.

Maybe easiest solution is to skip the copy/move dialog in general if source folder does not contain any files/folders.