Exceptions in new version

Hi @dstelljes!

We see a big performance degrade in creating the schema’s when switches to master (I think this is 3.0). I think this is because of the many exceptions being thrown in code like:

   foreach (var @case in Cases)
            {
                try
                {
                    return @case.Read(element, cache, scope);
                }
                catch (UnknownSchemaException exception)
                {
                    exceptions.Add(exception);
                }
            }

            throw new AggregateException($"No schema reader case matched {element.ToString()}", exceptions);

Such code is located in JsonSchemaReader, TypeResolver, BinarySerializerBuilder.

This is especially performance heavy when the type/schema is located at the end of the array.

For this POCO…

	public class Foo
	{
		public string Bar { get; set; }
		public DateTime Date { get; set; }
	}

… I’m currently getting 391 exceptions. All handled, but it takes a long time.

[promontis]

Cool! I’ll finish the PR tomorrow probably… if you can build a prerelease, we can just reference the nuget package and everything should work a lot faster!

Thanks for helping out 🤗 Closing

[dstelljes]

Also very slow for me when referencing source (a project reference to Chr.Avro.Confluent.csproj). When referencing it normally (a package reference to the NuGet release), the debugger doesn’t pick up any of the internal exceptions and the application runs much faster.

It’d definitely be possible to implement the case pattern without relying on exceptions, but it would be a significant amount of work and a breaking change for custom cases. Since this doesn’t affect project debugging unless a developer is referencing a local clone of Chr.Avro, I’m not sure it’s worth it.

A workaround may be to use [DebuggerHidden] or one of the other System.Diagnostics attributes.