Comparing Buffers produces massive test output

E.g.

fs.readFileSync("expected.png").toString()
    .should.equal(fs.readFileSync("actual.png").toString());

[logicalparadox]

Just FYI - You are going to want to leave them as buffers and use .deep.equal.

var actual = fs.readFileSync('actual.png')
  , expected = fs.readFileSync('expected.png');
actual.should.deep.equal(expected);

If two buffers are provided, deep equal will do a byte-to-byte comparison. Though, admittedly, it will still likely produce a huge output.

Back on topic…

Could add more types here? https://github.com/chaijs/chai/blob/master/lib/chai/utils/objDisplay.js#L38

[keithamus]

Yup @lucasfcosta you’re totally right!

> chai.expect(new Buffer(crypto.randomBytes(1000))).to.deep.equal(new Buffer(crypto.randomBytes(1000)))
AssertionError: expected <Buffer 87 a2 9b d0 34 be a0 30 bb 8a 44 29 e1 b3 e1 66 ca 14 67 dd e1 8e 4c d1 84 0d f5 25 c3 fb 87 6a 46 e8 28 cc 8d 99 7a b2 86 7b 36 75 25 02 4f 0c b4 35 ... > to deeply equal <Buffer 29 c3 4d e7 32 95 7c 5c a8 74 2a 2a 1e 4b fe 3e 0b 01 3d 58 e8 d5 df 60 31 d3 b3 86 da 66 cb fb c1 e8 4b 28 d2 df 06 b5 be 15 8b e1 1c 3e 14 3f 22 76 ... >

I’ll close this one for now as I think there’s nothing more that needs doing. If anyone sees any more problems with this, please file a new issue 😄