Several open Greenkeeper-PRs
See original GitHub issue@keithamus , @meeber I was sleeping for a whole while in this project - sorry for that.
But I`ve awoken and found an awful lot of Greenkeeper-PRs having a failing build. I want to tackle those PRs now but I want to talk a strategy with you first.
First of all, there is a lot of updated dependencies which simply fly around build-tooling. We could ask ourselves if we really need those updates.
Then there is a bunch of outdated PRs of updated dependncies. For example ESLint has PRs for laround 6 different Versions. For those, I would just close the old-version-PRs and only leave the newest ones - if we already gonna put work into this, then let’s do it right.
That should already clear the field for a better overview. What do you think?
Issue Analytics
- State:
- Created 7 years ago
- Reactions:1
- Comments:7 (7 by maintainers)
Top Results From Across the Web
Nobody else is going to have the honour of doing a 150th Open
Most are drawn from across St Andrews's seven courses, but some are experienced greenkeepers brought in from elsewhere to supplement the team.
Read more >The 147th Open - Life as a greenkeeper - YouTube
Rhys ap William goes behind the scenes with the greens staff as they prepare for the start of The 147th Open.--Keep in touch...
Read more >GREENSKEEPER – Official Website of the WM Phoenix Open
4 Greenskeeper credentials per day | Monday – Sunday; Complimentary breakfast and lunch buffet, snacks and open bar; 1 Valet parking pass |...
Read more >Greenkeepers Open - St Andrews Links : The Home of Golf
A team of almost 50 greenkeepers from golf clubs all over the United Kingdom and further afield will be supporting the home greenkeeping...
Read more >U.S. Women's Open provides valuable career opportunities for ...
U.S. Women's Open provides valuable career opportunities for greenkeepers · Often the unsung heroes at any golf tournament - the women who will ......
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Firstly
Please don’t ever feel guilty or apologetic for stepping back for a while. This is not your job, you should only do it when you feel happy to!
The PRs from greenkeeper are only meant to trigger for two reasons:
1 is really useful, because if the tests are passing for that new version, we can merge right away and all is fine. If the tests fail then we can investigate what the problem is, and potentially just close it as its out of our semver range.
2 should be just as useful, because any failure we should investigate and hopefully fix. Sadly most of these - in our case - are saucelabs failures. For example if we have a look at #48 - we can see the build (https://travis-ci.org/chaijs/type-detect/jobs/144520639) failed because IE9 timed out. Sadly this becomes a false negative - we’re warned about a failure but really it’s just saucelabs “uptime” issues. I’ve actually spoken to saucelabs about this but haven’t heard much back.
The point of this explanation is to demonstrate an ideal strategy for these PRs. So my proposed strategy is thus:
I’ll cc @meeber and @lucasfcosta to this so we can all discuss 😄
I don’t have any special access to saucelabs within travis, nor does the greenkeeper account, so to speak. It has a lot more to do with your second point:
^ This is how greenkeeper works. Any PR made from within this repo rather than a fork gets to use SauceLabs, because it is considered trusted code (as only a select few have access to write to this repo). Greenkeeper commits direct to this repo, therefore the tests are run on travis and given access to the saucelabs credentials.
So, @davelosert - as you have access to write to this repo, you are able to push to branches from within the repo, which will trigger a saucelabs test. If you want to play with the concurrency setting, feel free to do so in a branch from this repo (again, just to reiterate, not from your fork).