Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

xplat: examine _WIN64, should it be _M_X64?

See original GitHub issue

e.g. CallInfo.h, is following “unused” patch applicable to xplat x64?

        CallInfo(CallFlags flags, ushort count)
            : Flags(flags)
            , Count(count)
#ifdef _WIN64
            , unused(0)
#endif
        {
        }

        // Assumes big-endian layout
        // If the size of the count is changed, change should happen at following places also
        //  - scriptdirect.idl
        //  - LowererMDArch::LoadInputParamCount
        //
        unsigned  Count : 24;
        CallFlags Flags : 8;
#ifdef _WIN64
        unsigned unused : 32;
#endif

Issue Analytics

State:
Created 7 years ago
Comments:5

Top GitHub Comments

1reaction

jianchuncommented, Jun 23, 2016

I don’t like _M_X64 of _M_X64_OR_ARM64 as these are specific CPUs is the defines are just about 64 targets. BIT64 is better but not that descriptive. How about TARGET64 or HOST64?

+1 TARGET64

0reactions

jianchuncommented, Sep 29, 2016

We now have TARGET_64. But lots of code (including new code) still uses _WIN64. Needs to search for all and evaluate which should change to TARGET_64.