question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[AlertDialog] Merge with Modal

See original GitHub issue

Considering the AlertDialog basically is a Modal anyways, I propose merging them:

  • remove all references to AlertDialog
  • add isAlert or isAlertDialog to ModalContentProps which sets the role attribute accordingly

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:2
  • Comments:5 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
ljosberinncommented, Jul 27, 2020

I suspect you meant ...and _not_ equal to a Modal? Anyways I went ahead (and should’ve read this earlier) and filed a PR 😅 if we drop this one, I’ll file another one for the typings in there.

0reactions
ljosberinncommented, Aug 13, 2020

We talked on Discord about it and we will merge AlertDialog into Modal, but not remove it entirely for now.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Merge [alertdialog] and [android-alertdialog]
A subclass of Dialog that can display one, two or three buttons. If you only want to display a String in this dialog...
Read more >
Dialogs - Android Developers
The AlertDialog class allows you to build a variety of dialog designs and is often the only dialog class you'll need. As shown...
Read more >
AlertDialog and CustomDialog in Android With Kotlin. - Medium
In this blog, we are going to learn how to build AlertDialog and Custom dialog in android with kotlin language. you should have...
Read more >
The neatest way to handle alert dialogs in React
Interested? Let's write some code. First of all, we need to start with creating actually the modal dialog. This is just a simple...
Read more >
Alert Dialog - Components - Twilio Paste
Though it's visually similar to a Modal, an Alert Dialog requires the user to acknowledge the information in the dialog. Users cannot interact...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found