[Docs] GitHub Button in Docs Header not responsive
See original GitHub issueDescribe the bug When viewing the docs at chakra-ui.com on mobile, the GitHub button showing the number of stars isn’t responsive and forces the other header buttons out of the view.
Expected Behavior The header should look nice on mobile, without the badge being too big and forcing other buttons out of the view.
To Reproduce
- Go to chakra-ui.com on mobile
- See header in nav bar
Suggested solution(s)
The GitHubButton
has a Box
parent, so using responsive props we can simply add the following to Box
:
display={["none", "flex"]}
This removes any need to do any more mobile detection or CSS. Open to hear other suggestions though as it’s a bit annoying to have to declare flex
explicitly.
Desktop (please complete the following information):
- OS: iOS
- Browser: Safari
- Version: iOS 13.3, iPhone XS
Additional context Perhaps this could be put in the footer instead?
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (3 by maintainers)
Top Results From Across the Web
Buttons not working with fixed header/footers when ... - GitHub
When you have a fixed header/footer, if you scroll down so are not at the top or bottom, any buttons will not fire....
Read more >Button not responding to click in a fixed header after scrolling ...
Not sure if it's on my end or a bug but I have an issue of a button in my header not responding...
Read more >Working with non-code files - GitHub Docs
GitHub supports rendering and diffing in a number of non-code file formats.
Read more >API Authorization: header not working · Issue #4243 - GitHub
Using the /api/swagger web UI, hit the 'Authorize' button and put your token into the AuthorizationHeaderToken value field. Ensure you are ...
Read more >proper way to override close button behavior in Header and Tab
Current behavior I'm looking for a clean way to change the close behavior in headers and tabs. I tried a bunch different ways...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@segunadebayo force pushed to the same PR #502
@jackleslie, sure that’s fine as well. Kindly submit a PR