[Drawer] Height issue

Describe the bug A clear and concise description of what the bug is.

In Drawer (and possibly Modal), when scrollBehavior is set to “inside”, Drawer doesn’t fill the height of the screen.

Expected Behavior A clear and concise description of what you expected to happen.

Drawer, when opened from sides, should completely fill the heights of the screen, even with scrollBehavior set to “inside”

Steps to Reproduce Clear and concise reproduction instructions are important for us to be able to triage your issue in a timely manner.

Use this line:

<Drawer isOpen={isOpen} placement="right" onClose={onClose} size="sm" scrollBehavior="inside">
...
</Drawer>

Suggested solution(s)

in modal.js, line 28, we have

maxHeight: props.scrollBehavior === 'inside' ? 'calc(100vh - 7.5rem)' : undefined

This is the cause of the issue. I don’t know why we have that 7.5rem there, perhaps it has something to do with Modals, but it’s breaking the Drawer.

Can we remove this line?!

Desktop (please complete the following information):

• OS: MacOS
• Browser Chrome
• Version latest

[segunadebayo]

I’ve just pushed a fix for this @akiarostami. @with-heart you’re right, the drawer wasn’t connected to it’s theming and I just did that.

It should work as expected now.

@akiarostami It’s kinda tough to give a specific date. We’re currently in the rc stage of v1 and this means we’re getting pretty close to v1. I believe we’ll get it stable over the coming weeks.

[akiarostami]

hahaha… that is a comming practice @with-heart, at least whenever I go to see my doctor, that happens! 😃

I understand the “release schedule”, but since @segunadebayo said next week 2 weeks ago, I was wondering is there’s an update.