Editable should have validation possibilities

Feature request

We need our text to be required, right now there is no clear and concise way to validate and stop the user from submitting bad data. If you catch the bad data in onSubmit there is no way to cancel (reset editable state).

Is your feature request related to a problem? Please describe.

<Editable
   defaultValue={defaultValue}
   onSubmit={(e) => {
       if(someValidation(e)){
        //I need to cancel out and reset to previous state.
        //Im outside of EditableContext so i cant use useEditableState to call onCancel
       }
    }}
>...

Describe the solution you’d like

Provide the onCancel func to onSubmit as second param, similar to how formik provides you with “formikHelpers” to control the form behavior in different callbacks.

Describe alternatives you’ve considered

1. preferred, easy to implement - Provide internal editable state or just the onCancel into onSubmit.

2. Wrap controller in a <form> and use form events.

Additional context

relevant code onSubmitProp?.(value)

[Psvensso]

On second thought, current code also resets the internal state before the user could cancel out of the new value as proposed above. So this would not really work. I guess sending in a validate function prop would be easier and call that before updating the internal state would be the quickest way to allow validation on this.

Edit: I can whip up a PR but just wanted to sanity check it first if this is something we even want in there.

Something like this

export interface UseEditableProps {
  ...
  /**
   * Gets called before updating internal state and calling the onSubmit callback.
   * Is provides the next value and the onCancel method.
   */
  validate?: (
    nextValue: string,
    onCancel: (previousValue: string) => void,
  ) => boolean
}

const onSubmit = React.useCallback(() => {
    if (onValidateProp?.(value, onCancel) === false) {
      return
    }
    setIsEditing(false)
    setPrevValue(value)
    onSubmitProp?.(value)
  }, [value, onSubmitProp])

[mwhitlaw]

The feature request is definitely a good idea, but it appears to have been closed/ignored. Is there a way to revive this request?