[Link] disabled prop & interaction behaviour

Bug report

Describe the bug

The Link component has default visuals for _disabled. However, the typings do not reflect that and interactions are not actually prevented.

Expected behavior

I’d expect passing disabled to Link to prevent interactions and TypeScript not having issues with that.

• add disabled?: boolean to LinkProps
• add documentation for it via JSDoc
• adjust the props in the docs
• consider adding an example to the Link docs too
• all interactions (click, touch) have event.preventDefault() if disabled, otherwise execute props.onClick if present.

[jsefiani]

@segunadebayo Thank you for your feedback. I would like to add the following:

• The Link component becomes indeed non-interactive under the hood if you omit the href attribute, but what about the styling? The Link component still gives me (wrong) feedback (hover state) when no href is provided. Shouldn’t we apply a disabled styling when there’s no href?

[segunadebayo]

Hey guys,

Removing the isDisabled from the link component was intentional. Links are not buttons and shouldn’t have disabled in them. We want to be careful not to invent anti-patterns.

The way to make a link non-interactive is to omit the href attribute.

Permit me to close this as well as the PR.

Thanks guys 💖