[SlideFade] findDOMNode deprecation warning in StrictMode
See original GitHub issueDescribe the bug findDOMNode warning when using StrictMode (v1 rc.0)
Reproduction: https://codesandbox.io/s/trusting-nightingale-kiij9?file=/src/index.tsx
To see the bug - toggle the animation and see the console.
This is because we don’t use the nodeRef
prop when using the react-transition-group
(you can read more about the nodeRef prop in the changelog) We can’t really use it without changing the API either, so I can’t really create a good PR to fix it without discussing the API implications with you.
One proposed API is changing the returned function value to include ref as well, changing the API from this
<Fade in={isVisible}>
{style => <Box style={style} />}
</Fade>
to this:
<Fade in={isVisible}>
{fadeProps => <Box {...fadeProps} />}
</Fade>
where fadeProps
is an object containing the following:
{
style: style,
ref: nodeRef,
}
Issue Analytics
- State:
- Created 3 years ago
- Reactions:5
- Comments:15 (8 by maintainers)
Top Results From Across the Web
Warning: findDOMNode is deprecated in StrictMode ...
This is the warning i am receiving in the console. Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of ...
Read more >CHANGELOG.md - TINMAN
`@material-ui/core@v3.7.0` #### Deprecations We are allowing more align variants (left, center, right, ... Fix more StrictMode warnings (#13590) @eps1lon.
Read more >front-end/node_modules/@material-ui/styles/CHANGELOG.md
The introduction of deprecation messages in the next v4 minors. These messages will help developers ... Fix more strict mode warnings (#16525) @eps1lon....
Read more >material-ui/core/CHANGELOG.md - UNPKG
60, - [docs] Fix fullWidth deprecation warnings (#14010) @ ... 509, - ⚛️ Fix some React 16.6.0 warnings in StrictMode (#13498, ... findDOMNode(node);....
Read more >CHANGELOG.md · 脚本测试11/material-ui - Gitee.com
... .org/docs/strict-mode.html#warning-about-deprecated-finddomnode-usage). ... (#7736) @Merkyl999x #### Core - [core] Flow type transitions Slide, Fade, ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Should be since
rc.6
since we useframer-motion
internally now!Looks like the changelog hasn’t been update for RC5, that’s unfortunate. Here’s an excerpt I manually posted on Discord at the time:
rc.4
color mode issues should be resolvedCheckbox
checked icon can be customized viaicon
propNode v10 compatibility restored
iOS 13 media query list issue fixed
ColorModeScript
prop for color mode is now calledinitialColorMode
just like intheme.config
docs are updated
and 4. had issues however, they have been fixed since.