question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[SlideFade] findDOMNode deprecation warning in StrictMode

See original GitHub issue

Describe the bug findDOMNode warning when using StrictMode (v1 rc.0)

Reproduction: https://codesandbox.io/s/trusting-nightingale-kiij9?file=/src/index.tsx

To see the bug - toggle the animation and see the console.

This is because we don’t use the nodeRef prop when using the react-transition-group (you can read more about the nodeRef prop in the changelog) We can’t really use it without changing the API either, so I can’t really create a good PR to fix it without discussing the API implications with you.

One proposed API is changing the returned function value to include ref as well, changing the API from this

<Fade in={isVisible}>
  {style => <Box style={style} />}
</Fade>

to this:

<Fade in={isVisible}>
  {fadeProps => <Box {...fadeProps} />}
</Fade>

where fadeProps is an object containing the following:

{
  style: style,
  ref: nodeRef,
}

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:5
  • Comments:15 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
ljosberinncommented, Nov 1, 2020

Should be since rc.6 since we use framer-motion internally now!

1reaction
ljosberinncommented, Oct 22, 2020

Looks like the changelog hasn’t been update for RC5, that’s unfortunate. Here’s an excerpt I manually posted on Discord at the time:

  1. rc.4 color mode issues should be resolved

  2. Checkbox checked icon can be customized via icon prop

  3. Node v10 compatibility restored

  4. iOS 13 media query list issue fixed

  5. ColorModeScript prop for color mode is now called initialColorMode just like in theme.config

  6. docs are updated

  7. and 4. had issues however, they have been fixed since.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Warning: findDOMNode is deprecated in StrictMode ...
This is the warning i am receiving in the console. Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of ...
Read more >
CHANGELOG.md - TINMAN
`@material-ui/core@v3.7.0` #### Deprecations We are allowing more align variants (left, center, right, ... Fix more StrictMode warnings (#13590) @eps1lon.
Read more >
front-end/node_modules/@material-ui/styles/CHANGELOG.md
The introduction of deprecation messages in the next v4 minors. These messages will help developers ... Fix more strict mode warnings (#16525) @eps1lon....
Read more >
material-ui/core/CHANGELOG.md - UNPKG
60, - [docs] Fix fullWidth deprecation warnings (#14010) @ ... 509, - ⚛️ Fix some React 16.6.0 warnings in StrictMode (#13498, ... findDOMNode(node);....
Read more >
CHANGELOG.md · 脚本测试11/material-ui - Gitee.com
... .org/docs/strict-mode.html#warning-about-deprecated-finddomnode-usage). ... (#7736) @Merkyl999x #### Core - [core] Flow type transitions Slide, Fade, ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found