Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature Request]: export an instantiated chance object

See original GitHub issue

Current Behavior

Currently we have a lot of boilerplate code and a lot of instantiated chance objects in our test files:

import Chance from 'chance';

const chance = new Chance();

Expected Behavior

Provide an instantiated chance object to consumer:

import {chance} from 'chance';

Issue Analytics

State:
Created 5 years ago
Reactions:3
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

TheLarkInncommented, Jun 23, 2018

HI! I haven’t quite been sure if I want to submit the PR yet for fix some tests, but would something like this work?

https://github.com/chancejs/chancejs/compare/master...TheLarkInn:feature/rewrite-to-modules?expand=1

See the test changes.

0reactions

victorquinncommented, Jun 27, 2018

Sorry for the long response, but generally I always envisioned making this the default in 2.x which I also hoped to pair with the code splitting which it seem like may be implemented in @TheLarkInn 's change though I haven’t had time to dig into it in depth yet.

But I’ve always regretted returning the constructor and expecting folks to instantiate it. While that has its upsides (flexibility of seed), it comes with a lot of downsides (PITA having to instantiate which is counter-intuitive and not the way most node modules function in 2018).

Anyway, tentatively feeling good about it, but want to make sure it isn’t a significant breaking change.