question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add support for `ignored` config

See original GitHub issue

I’ve discussed this briefly with @mitchellhamilton yesterday and he has validated my idea and asked me to create an issue about it for further discussion.

Problem

It seems useful to be able to opt-out of auto-publishing sometimes. Most notably when adding a new package (but working on it gradually) or working on a new version of a particular package without entering pre mode for it (might be overkill).

Currently, there is no such way, "private": true works the same way as other packages - it just aint being published to npm, but it’s a subject to changelog/tag generation and dependencies bumps. At first it has been suggested that this use case has already been discussed here, but actually it hasn’t. This one is not about changing how changesets manage dependencies permanently (a very core logic) but rather just about “muting” certain packages temporarily.

Proposed solution

Introduce ignored list - it would simply skip its entries in @changesets/assemble-release-plan.

Things to take care of so a cohesive experience can be provided

  • dependencies should still be bumped (written to package.json), but it wouldn’t trigger a new release
  • changesets for ignored packages should be kept and shouldn’t affect the release flow
  • we should throw for “mixed” changesets (containing ignored and not ignored packages)

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:10 (8 by maintainers)

github_iconTop GitHub Comments

2reactions
emmatowncommented, Jan 30, 2020

A builtin config has an important (IMHO) advantage over the ability to just manipulate a release plan - it can be implemented in a safer manner, with some opinions about how such feature should work ofc, so it still maybe wouldn’t be able to cover all the use cases, but I think that an opinionated builtin solution would be good as this use case here doesn’t seem to be overly rare.

I agree with this.

I think that if we can get away with not allowing people to manipulate release plans, we should do it.

2reactions
Andaristcommented, Jan 30, 2020

It’s unclear to me whether it’s better to add ignore as config, or add the ability for a user to write something like the above (with probably a guide to doing it and base function) that they can plug in.

That’s definitely a hard decision to make 😉 A builtin config has an important (IMHO) advantage over the ability to just manipulate a release plan - it can be implemented in a safer manner, with some opinions about how such feature should work ofc, so it still maybe wouldn’t be able to cover all the use cases, but I think that an opinionated builtin solution would be good as this use case here doesn’t seem to be overly rare.

That being said - I think it would be extremely useful to expose some hooks as you have described, so people could manipulate stuff according to their needs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add support for `ignored` config · Issue #242 - GitHub
Proposed solution. Introduce ignored list - it would simply skip its entries in @changesets/assemble-release-plan . Things to take ...
Read more >
Ignored config is exported with other config changes - Drupal
Hi, I've created a custom module in my Drupal 8 instance, which contains some custom configuration forms. That configuration may differ for ...
Read more >
Config ignore module tutorial for Drupal - Bulcode
Today I'm gonna show you another configuration-related module for Drupal 8/9 – Config Ignore. They are partially overlapping with each other.
Read more >
Config Ignore Auto: How To Change Drupal 8 Configuration ...
The generally accepted best practice (to this point) has been to use the Config Ignore module to define specific settings that are ignored...
Read more >
Ignoring False Positives - Brakeman
The -I option (or --interactive-ignore if you are not into the whole brevity thing) is the simplest way to create and manage an...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found