question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Changesets ignoring the skipCI config key

See original GitHub issue

Affected Packages

pkg:cli

Problem

Setting the config.json this way

{
  "$schema": "https://unpkg.com/@changesets/config@0.3.0/schema.json",
  "changelog": "@changesets/cli/changelog",
  "commit": true,
  "skipCI": false,
  "linked": [],
  "access": "restricted",
  "baseBranch": "master"
}

when changesets commits in CI, the comit message still contains skipCI

Proposed solution

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (1 by maintainers)

github_iconTop GitHub Comments

3reactions
Novinycommented, Mar 11, 2020

Had a really quick look into it, and we deprecated the skipCI flag with our version 2 upgrade, as all use-cases where people wanted commit: true, they also wanted skipCI true, and we add the skipCI flag to all our commits.

Happy to leave this open as ‘we should reimplement this to allow fine-grained controls’ but for an immediate fix you can set commit to false and run:

echo "+++ :npm: Publishing to NPM :npm:"
yarn changeset version
git add . && git commit -m "versioned packages"
yarn changeset publish 

My two take-aways from this is we should add skipCI back as its own flag, defaulting to true (what most people have wanted) and fine grain commit so you can set it per command that can commit.

Thanks for raising this!

1reaction
jordan-simonovskicommented, Mar 12, 2020

Ah right! Yeah we made a workaround using the manual commit in our CI pipelines. Thanks for doing such a great job on this project!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Changesets ignoring the skipCI config key · Issue #285 - GitHub
I have an issue because with our PR merges all commits are condensed down to a single commit and the commit message contains...
Read more >
Solved: Exclude changeset for [skip ci] not working
Solved: I'm currently using Bamboo version 6.9.2 build 60911 and have been facing a problem with the exclude changeset property on linked.
Read more >
gitblit - Jenkins
... is to use the Git commit's "Committer" value in Jenkins' build changesets. ... insensitive) the pattern "[ci skip]" or "[skip ci]" will...
Read more >
Actually you don't need 'semantic-release' for semantic release
1. Git configuration. To make a commit you need a committer: just name and email that will be associated with author. Also PAT...
Read more >
Changeset f387165 – Trac Demo 1.4 - Edgewall Software
Changeset f387165 in trac.git. View differences ... Ignore: Blank lines. Case changes. White space changes ... 265, `extras` keys in the setup file:....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found