patch+minor changesets resulting in major version bump

Affected Packages

pkg:cli

Problem

Somehow minor changes are resulting in a major version bump. If you look at the PR being updated at: https://github.com/ianstormtaylor/slate/pull/4156 — prior to adding a few minor changesets it was correctly putting the next versions at 0.61.4, but now it says 1.0.0 despite no changesets listing major changes.

I’m worried to merge it now for what it will do.

---

Edit: I think this may be similar to https://github.com/atlassian/changesets/issues/524, but I don’t quite understand exactly what is going on here in the first place.

[Andarist]

Im on mobile and its 5am so i cant confirm in full - but yes, probably the reason is the same as in other issue.

At the beginning Changesets wanted to play safe - lifting the some burden from the users but it turns out that this is just not what people expect (hence the extra unsafe flag that might become the default or smth in the next major version)

Imagine this:

1. Add a feature to your pkg which is a peer dep
2. Dont use it yet in a dependant
3. After some months start using it
4. Locally it works - tests run against the latest versions of your packages
5. The next release is broken for your consumers since u forgot to bump the peer dep range

From what I understand this is reasoning behind this behavior but i was not around when it was introduced so i might also miss some context

[alcuadrado]

Doesn’t npm7, which is aware of peer dependencies, make not bumping the dependent to a new major more reasonable? If an in-range update is required, npm will do it.

This is still very fuzzy in my mind to be honest, as it depends on how the user declared/installed the peer dependency. It works with a caret, may not work for others.