[Question] understanding better how to detect affected packages
See original GitHub issueHello,
I love the changeset approach and how it makes the process more friendly by letting the contributors to review and modify things before releasing.
I’m waiting for the NRWL support #801 to try it with our mono-repo, but till then I would like to raise a concern and ask how you tackle it.
In the automatic semver process, the detection of which libraries were affected is done for you automatically so there is no place for human mistakes.
Assuming you committed something like feat: support product analytics
and that commit includes changes in both pkgA and pkgB then the version of both will be increased.
but when adding changeset, I understand that while adding the changeset you select the relevant libraries. So what happens if for the same example as above you select only pkgA? In that case although we changed pkgB we will not deploy it and it might cause problems if pkgA depends on pkgB.
I would love to hear how this is handled in changeset.
Thanks again. looking forward to use the libraries.
Eran
Issue Analytics
- State:
- Created a year ago
- Reactions:1
- Comments:7 (2 by maintainers)
Top GitHub Comments
@mkotsollaris this is already supported, you can select the “changed packages” here:
@Andarist
any update? i have the same problem.
config.json -> "linked": [["ui-icon", "ui-button"]]
but when i do a manualyarn changeset
after do some change on “ui-icon” the output is:--- "ui-icon": minor ---
should expect
"ui-button": minor
too , no?