Unexpected peerdependent bump to 1.0.0 in pre mode
See original GitHub issueProblem
I have a branch in pre
mode, and I don’t understand why Changesets is planning on bumping this peerdependent to 1.0.0, even if the dependency’s new version perfectly satisfies the specified range (0.11 is >= 0.9, right?)
I would have expected the specified peer dependency range to remain intact, and the dependent’s version not to be bumped to 1.0.0.
To clarify, bumping the peer dependency range would be acceptable (even if I did not expect it), but the bump to 1.0.0 is not.
My config.json:
{
"$schema": "https://unpkg.com/@changesets/config@2.0.0/schema.json",
"changelog": "@changesets/cli/changelog",
"commit": false,
"fixed": [],
"linked": [],
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "minor",
"ignore": [],
"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
"onlyUpdatePeerDependentsWhenOutOfRange": true
}
}
Version of changesets in use is 2.24.4.
Link to PR and repository: https://github.com/hmans/miniplex/pull/126/files
Thanks!
Issue Analytics
- State:
- Created a year ago
- Comments:11 (4 by maintainers)
Top Results From Across the Web
Version bumped because of peerDependencies even if the ...
Currently we bump the major version of a package if it has a peerDependency on another package even if the version range still...
Read more >Changelog | skuba - GitHub Pages
template/lambda-sqs-worker*: Bump Node.js version to 18 (#1049). This release contains some breaking changes to the Lambda runtime such as the removal of ...
Read more >JupyterLab Changelog — JupyterLab 3.6.0b0 documentation
The Simple Interface mode (previously Single Document Mode) is now more streamlined. JupyterLab now supports showing the current file in use in the...
Read more >Npm Including all range of pre-release when defining peer ...
The need is basically ^1.0.0 with everything including pre-releases that happens to have 1 as major as peer dependency.
Read more >npm-update
So the highest-sorting version that satisfies ~1.1.1 is used, which is 1.1.2 . Caret Dependencies below 1.0.0. Suppose app ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I’m having the same issue, pkgB has pkgA as peerDependency.
PkgB is bumped to 1.0.0 instead of next minor version.
PkgA is bumped to next minor correctly.
One additional idea is that perhaps for the
>=
range we could “upgrade” it to smth like “>=0.9.0 || >=0.11.0-0.next.0”:Then we could even “bring back” the original range when exiting the premode.