`pull_request_closed_no_merge` metric is broken
See original GitHub issueDescribe the bug:
The pull_request_closed_no_merge
metric returns a 500 internal server error.
To Reproduce: Steps to reproduce the behavior:
- Checkout
dev
- Run
augur run --disable-housekeeper
- Hit
http://localhost:5000/api/unstable/repo/21000/pull-request-closed-no-merge
- Observe error
Expected behavior: I expected the metric to return a valid response object, even if it was empty.
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: macOS v 10.14.6
Additional context
I noticed that there is a missing GROUP_BY
clause in the SQL query, based on the usage of COUNT
. This appears to be the main culprit of the issue.
Broken Travis build: https://travis-ci.org/chaoss/augur/builds/657396384
Issue Analytics
- State:
- Created 4 years ago
- Comments:7 (7 by maintainers)
Top Results From Across the Web
EM 12c, EM 13c: Troubleshooting the Metric Collection Error ...
The 'Metric Collection Error' status for a database target in Enterprise Manager (EM) Cloud Control means that ... IOException: Broken pipe.
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I didn’t even notice this earlier, but the metrics API test is also failing because the route is incorrect. It should be
...unstable/repos/...
instead of.../unstable/repo/
- this is why it’s returning a 404. I’d also suggest using the same repo ID in both your metric and API test.Check out this line of the metrics test: https://travis-ci.org/chaoss/augur/jobs/657396385#L581. You’ll see the SQL error I’m referring to