Control secrets access

When creating an experiment we can pass secrets based on the variable environment,

  "secrets": {
    "vault": {
      "token": {
        "type": "env",
        "key": "VAULT_TOKEN_"
      },
      "address": {
        "type": "env",
        "key": "VAULT_ADDR"
      }
    }
  }

Now we should be able to access them in the controls (e.g. the control.py file I provided)

"controls": [
    {
        "name": "tracing",
        "provider": {
            "type": "python",
            "module": "my_module.control"
        }
    }
  ]

The first control that is called (i.e. configure_control)

def configure_control(
    configuration: Configuration = None,
    secrets: Secrets = None,
    settings: Settings = None,
    experiment: Experiment = None,
):

successfully converts the templates:

  "token": {
    "type": "env",
    "key": "VAULT_TOKEN_"
  },
  "address": {
    "type": "env",
    "key": "VAULT_ADDR"
  }

into real value. and I can access them via the secrets parameter.

Yet all the other controls:

• before_experiment_control
• after_experiment_control
• before_hypothesis_control
• after_hypothesis_control
• before_method_control
• after_method_control
• before_rollback_control
• after_rollback_control
• before_activity_control
• after_activity_control

have the secret parameter, but all of them get None value (it’s the default value - meaning no secrets was provided) how do we get secrets in other controls functions? or why we don’t get them? could not find any relevant information in the doc

[michael-gehtman-wix]

sure, ill check it out ASAP, thank you very much.

[Lawouach]

The docs will eventually reflect whichever we go for as well.