Incomplete type definition for translatePathFromContext

translatePathFromContext says it returns a Promise<DrupalTranslatedPath>

If you look at the code for that method, it returns:

return await this.translatePath(path, {
      withAuth: this.getAuthFromContextAndOptions(context, options),
    })

translatePath says it also returns a Promise<DrupalTranslatedPath>, but in fact can also return null:

if (!response?.ok) {
      // Do not throw errors here.
      // Otherwise next.js will catch error and throw a 500.
      // We want a 404.
      return null
    }

In our app code, with no-unnecessary-condition enabled, this causes a problem:

Typescript rightly doesn’t think path can be null, because it’s being told translatePathFromContext will always resolve to a DrupalTranslatedPath.

I imagine there are other signatures like this that are also not complete enough, any thoughts?

[shadcn]

Hmmm this does look like a bug. Let me look into it.

I wonder if I missed this because I have strict mode turned off.

[martdavidson]

Not a blocker, and also heading into vacation so no worries! Happy holidays!