Action points

Before we move forward we need to deal with some HP issues.

omitBy tests

when running prettier on tests/omitBy.js it will change the source code. This also need to be resolved ASAP.

Linting & prettier workflows

It is not clear how we currently use this. We have eslint-config-prettier and eslint-plugin-prettier that should integrate with eslint. So we should be OK just having lint and lint:fix scripts that are running prettier under the hood as an eslint rule implicitly. If I understand this correctly (https://github.com/prettier/eslint-plugin-prettier) than running lint should tell us what needs to prettyfied. If it works like that then all our problems are solved. Runnling lint shows us linting issues (including AST issues detected by prettier, and doesn’t modify the code) and lint:fix will fix them (modifies the code). on CI we will still run only lint script and it should tell us if somebody broke some eslint rule or did not properly format code with prettier running lint:fix. Having pre/post commit hooks is secondary now, this needs to be addressed ASAP. Also our lint:fix is currently defined as “lint:fix”: “better-npm-run lint:fix” but bnr doesn’t have any script named lint:fix so it fails.

There are also some incosistencies between eslint & prettier that need to be addressed.

> eslint --print-config .eslintrc | eslint-config-prettier-check

The following rules are unnecessary or might conflict with Prettier:

- comma-dangle
- semi

Communication organization

I am finding it hard to maintaining contexts in all the issue threads that are currently being discussed. If you need decision on something, please summarize all the previous comments of the issue in one comment, include props and cons, describe the consensus or opinion differences and I’ll try to decide so that we can move forward on the particular issue and have at least some working POC.

[char0n]

@Undistraction there was no problem, it was just unclear how to use it, how it integrates with eslint etc…see the description of this issue (Linting & prettier workflows). I created a PR which fixes the integration, by modified this line https://github.com/char0n/ramda-adjunct/pull/388/files#diff-1dc6ee56b778cd91e0327b52aaeaa1b9L15 + fixing some package.json problems.

Now the workflow is the same as it was before. Before push, one have to lint and if there are errors he should lint:fix.

[Undistraction]

@char0n Ok. I thought there was some kind of crisis:

This also need to be resolved ASAP.

I’m glad it’s sorted.