Git hooks (prepush/precommit)

This issue is a continuation of #379 discussion about git hooks.

Related issues : #301, #313, #314

I think adding a prepush hook is very good idea, I personally run prepublishOnly before every of my push.

But for precommit I disagree, it’s unpleasant to wait for it, and lint-staged cannot be used because okonet/lint-staged#62

[wojpawlik]

It looks like it is in general not trivial to fix files in pre-commit and do the right thing with partly staged files, pretty-quick apparently can’t do that too: https://github.com/azz/pretty-quick/issues/6.

Maybe the easiest thing to do would be to just validate all the files, don’t try to autofix in pre-commit.

Also, if there are files which prettier would reformat, prettier -l` prints file names and exits with status code 1.

[wojpawlik]

Update:

lint-staged works by passing filenames to eslint (at least their Readme says so), which means it checks version of the file in working directory instead of index. Can be solved by using a simple bash script instead.

But…

Anyway, `npm run + husky + lint-staged + commitlint1 is not about waiting 1 second but 3-4 seconds, I do not like to wait so much. 1 second would be fine. (https://github.com/char0n/ramda-adjunct/issues/386#issuecomment-366728977)

@guillaumearm I have to agree with you here. To a point that I’m myself wondering if any hooks near commiting are worth it.

Especially pre-commit, when now that prettier is run from within eslint, which makes my VSCode fix everything on save (it’s awesome), and entire project will be linted anyway on pre-push…

I’ll probably open a PR adding pre-push and commit-msg hooks. I think I’ll add each hook in separate commit, so that it’d be easier to merge it only partially. Might as well throw in pre-commit.