Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Use chai directly instead of internal `eq` function in test asserts

See original GitHub issue

Appropriate assert functions from chai should be used to be more explicit.

Code like this:

describe('ensureArray', function() {
  context('given argument is not an array', function() {
    specify('should wrap value into singleton array', function() {
      const arrayPrototype = Array.prototype;

      eq(RA.ensureArray(void 0), [void 0]);
      eq(RA.ensureArray({}), [{}]);
      eq(RA.ensureArray(null), [null]);
      eq(RA.ensureArray(undefined), [undefined]);
      eq(RA.ensureArray(42), [42]);
      eq(RA.ensureArray('Array'), ['Array']);
      eq(RA.ensureArray(true), [true]);
      eq(RA.ensureArray(false), [false]);
      eq(RA.ensureArray({ __proto__: arrayPrototype }), [
        { __proto__: arrayPrototype },
      ]);
    });
  });
});

has to become like this:

import { assert } from 'chai';

describe('ensureArray', function() {
  context('given argument is not an array', function() {
    specify('should wrap value into singleton array', function() {
      const arrayPrototype = Array.prototype;

      assert.sameOrderedMembers(RA.ensureArray(void 0), [void 0]);
      assert.sameDeepOrderedMembers(RA.ensureArray({}), [{}]);
      assert.sameOrderedMembers(RA.ensureArray(null), [null]);
      assert.sameOrderedMembers(RA.ensureArray(undefined), [undefined]);
      assert.sameOrderedMembers(RA.ensureArray(42), [42]);
      assert.sameOrderedMembers(RA.ensureArray('Array'), ['Array']);
      assert.sameOrderedMembers(RA.ensureArray(true), [true]);
      assert.sameOrderedMembers(RA.ensureArray(false), [false]);
      assert.sameDeepOrderedMembers(
        RA.ensureArray({ __proto__: arrayPrototype }),
        [{ __proto__: arrayPrototype }]
      );
    });
  });