question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ignore (?#comment) when checking for existing watch/blacklist entry

See original GitHub issue

When adding a new watch or blacklist entry, the code tries to check for existing entries which match the proposed addition. However, with (?#comments) in some regexes, you currently have to have the same comment in order for the check to successfully detect duplicates.

I’d like for the code to remove any (?#comments) from both the proposed addition and the entries it checks before making the comparison.

Any (?#comments) in the proposed addition should of course be preserved in any entry which ends up ultimately being added.

As a bonus, perhaps also try to normalize ? vs * vs + and other common variations in regexes.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:10 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
angussidneycommented, Sep 24, 2018

Possible hacktoberfest issue?

0reactions
makyencommented, Sep 13, 2019

Resolved with 9a71561

Read more comments on GitHub >

github_iconTop Results From Across the Web

Blacklist - exclude users and groups from use
Blacklist - exclude users and groups from use. Determine which users and groups are excluded from usage within ARM for granting and removing...
Read more >
How to make Metro (React Native packager) ignore certain ...
In your project root create rn-cli.config.js with the contents: const blacklist = require('metro-bundler').createBlacklist; module.exports = { getBlacklistRE: ...
Read more >
Enable and Disable Comments | WordPress.com Support
The Block User button will add the comment author to the site blacklist, blocking them from writing new comments on your site. Comment...
Read more >
How to Stop WordPress Spam Comments (Built-In Features ...
To create a list of blacklisted words, go to the Comment Blacklist field and type in the blacklisted words or phrases, one per...
Read more >
[Solved] Remove Google Blacklist warning from your Website
If you are seeing this Google blacklist warning, act fast. The first thing to do is scan your website to be 100% sure...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found