Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Check config in a correct place too (options.plugins)

See original GitHub issue

Currently this plugin waits for config in options.zoom and options.pan while the correct place for them is options.plugins.zoom and options.plugins.pan respectively (https://www.chartjs.org/docs/latest/developers/plugins.html#plugin-options). This problem also makes a pain to use the plugin with TypeScript, because it doesn’t expect options to contain zoom and pan properties and emits an error.

Issue Analytics

State:
Created 5 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

3reactions

benmccanncommented, Jan 30, 2019

We could read from both locations now and remove the old one at 1.0. We could add a TODO(1.0) in the code to track in lieu of an issue

1reaction

simonbrunelcommented, Jan 30, 2019

@PaulAnnekov This problem also makes a pain to use the plugin with TypeScript

FYI, DefinitelyTyped/DefinitelyTyped#31440 now allows to extend the TypeScript definition for the plugin options. That means plugins can independently provide declaration files for their public API. For example, the datalabels plugin now exposes these types in the /types folder (9e0026597).