cart.refresh() should return the cart, rather than the cart ID

Should we create a getter method within the root commerce.js class that proxies/returns the cart instance variable that’s within the Features.Cart instance created within commerce.js that’s assigned as this.cart?

A use-case is: (two methods within a React.Component)

// retrieveCart
retrieveCart(){
    commerce.cart.retrieve().then(cart => {
      this.setState({
        cart
      })
    }).catch(error => console.log(error));
  }

// refreshes cart
refreshCart(){
    commerce.cart.refresh().then(resp => {
      this.retrieveCart() 
      // instead of invoking this.retrieveCart to retrieve the new/refreshed cart 
      // we should avoid an additional request (commerce.cart.retrieve internally invokes commerce.cart.request method, as does commerce.cart.refresh)
      // instead we can ref the cart object that's an  instance variable in commerce.cart (ex: commerce.cart.cart)
      // (it used to only have the cartId ex. commerce.cart.cartId)
      this.setState({
        cart: commerce.cart.cart
      })
    }).catch(error => console.log(error))
  }

The issue with this is that a developer won’t know the cart instance variable exist within commerce.cart unless they debugged, or got into the source code. I think having a getter within the root commerce class like commerce.cartObject that returns the cart object instance variable living within commerce.cart as commerce.cart.cart.

[robbieaverill]

Make cart.refresh return the new cart object rather than the ID? Should be an easy change to make, and we can still do this for v2

[ScopeyNZ]

Ok the issue here is that refresh should give you back the cart.

I wasn’t implying that cart.refresh returning the cart gets into state management, but providing and recommending API that exposes the internal .cart object would be.