Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve docker support

See original GitHub issue
  • I think it would be better to only copy in the app and not the config
  • I think the docker image itself should be responsible for running the and not the docker compose file
  • I think the docker image should be published to docker hub from this repo (Only @chibicitiberiu can set this up, I setup a fork to build but only he or someone with repo access can do that so that it’s up to date)
  • Config/data should be VOLUME’d and port should be EXPOSED’d

All of this would allow for someone to do the following:

$ docker pull chibicitiberiu/ytsm
$ docker run chibicitiberiu/ytsm -v /path/to/my/config:/config -v /path/to/my/media:/media

The docker compose file is a nice touch but I think it currently has too much “Responsibility” as in the docker image should stand on it’s own and the docker compose file should make use of that image and setup other things (nginx/db) so that people can use their own reverse proxy/db but the compose file is an example of how to get things up and running quick (to that end I think the default should be sqlite with an option to use another DB).

I’m not sure if this is the best place to discuss this and I’m happy to move the discussion to an issue or elsewhere.

Edit: Also I think we need a way to move the DB config out of so that it can be set via the INI config file

_Originally posted by @joshstrange in

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:1
  • Comments:24 (9 by maintainers)

github_iconTop GitHub Comments

chibicitiberiucommented, Oct 31, 2018

I forgot to remove some options from (such as YT API key, and a few others) that I used in early development, I can clean that up.

The config.ini parser supports using environment variables using the syntax ${env:SOMETHING}, perhaps we could provide a config.docker.ini which takes configuration from environment variables.

I agree that database should also be included in config.ini. I think it is possible to build the file dynamically at runtime, I’ve seen examples where they checked an environment variable for selecting between development and production. There’s also #7 which involves cleaning up

I have a busy week, not sure if I can get anything done until Saturday, if someone wants to take that until then, let me know.

PBXg33kcommented, Oct 31, 2018

@joshstrange Sorry to address you separately. Saw your comment after i posted previous message.

I agree with you on the points, i would fork and patch on my end if i had the time to work on it, but that would be a hack/workaround with minimal changes to the python code because my lack of experience with it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Speed boost achievement unlocked on Docker Desktop 4.6 ...
Speed boost achievement unlocked on Docker Desktop 4.6 for Mac ... A 90% improvement in the time taken to complete a 284MB MySQL...
Read more >
How to Optimize Docker Performance | Scout APM Blog
Read to learn different methods of optimizing Docker performance and get answers to frequently asked questions about the technology.
Read more >
Instantly Improve Docker Performance on Mac - Nimbus
Docker performance on Mac has a poor reputation and performance. Let's talk about why that is and what you can do to improve...
Read more >
How to Optimize Docker Performance - phoenixNAP
Optimize Docker performance by learning about the performance-affecting factors and applying the optimization tips listed in this article.
Read more >
Docker Performance Improvement: Tips and Tricks - Stackify
Gathering container metrics. When it comes to measuring container performance, we'll need metrics to help us understand our current performance.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found