Banana Cake Pop OAuth2 broke with V2
See original GitHub issueIs there an existing issue for this?
- I have searched the existing issues
Describe the bug
I use the downloaded version of Banana Cake Pop, and was able to use OAuth2 perfectly. But ever since updating to BCP 2.0.0, my OAuth flow logs me in, and then throws “Either the parameter query or the parameter id has to be set”
Full error: {"errors":[{"message":"Either the parameter query or the parameter id has to be set.","extensions":{"code":"HC0013"}}]}
I tried downgrading back to BCP 1.0.0 but since today that has started throwing CORS errors so I assume something changed serverside?
The only issue I found related to this error is one where it’s said that you should use the client and not the web browser for OAuth, but I am doing that.
Steps to reproduce
The OAuth2 provider I’m using is Azure AD. Authenticating with OAuth2 with “Implicit” grant type, and “Access token” as response.
Relevant log output
Error code show in popup window:
{"errors":[{"message":"Either the parameter query or the parameter id has to be set.","extensions":{"code":"HC0013"}}]}
Error shown in dev console:
DOMException: Blocked a frame with origin "banana-cake-pop://app" from accessing a cross-origin frame.
at banana-cake-pop://app/static/js/243.082d6152.chunk.js:1:114770
Additional Context?
Product
Banana Cake Pop
Version
2.0.0
Issue Analytics
- State:
- Created a year ago
- Comments:9 (5 by maintainers)
Top GitHub Comments
Yes! Thanks for the quick help! I’ll patiently wait for the V2 fix now 😃
No worries, it’s an open source project and i really appreciate your hard work on this! 🏅 👍