Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PEP8: how can we avoid breaking API

See original GitHub issue

Parts of the library do not follow PEP8 names.

I took a look at /examples and compiled the names there imported:

class pymbar.MBAR (+ its methods)
class pymbar.PMF (+ its methods)
class pymbar.utils.DataError
class pymbar.utils.ParameterError
function pymbar.BAR
function pymbar.confidenceintervals.AndersonDarling
function pymbar.confidenceintervals.generateConfidenceIntervals
function pymbar.confidenceintervals.QQPlot
function pymbar.EXP
function pymbar.EXPGauss
function pymbar.timeseries.statisticalInefficiency
function pymbar.timeseries.subsampleCorrelatedData
function pymbar.utils.kn_to_n

These should either:

A. left alone for now, or B. be an alias to the PEP8-compliant name with a DeprecationWarning

We should probably include more names in that list, but the question is the same: how do we want to face these changes?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

mrshirtscommented, Feb 25, 2020

That seems like it might be a good path forward. There are a couple of actual improvements / bug fixes that have been found / we may find over the next couple weeks that we should backport as well.

Issue filed at #364 to make a list

mrshirtscommented, Feb 28, 2020

Closing this, since the solution is #365

Read more comments on GitHub >

github_iconTop Results From Across the Web

PEP 8 – Style Guide for Python Code
Use 4 spaces per indentation level. ... The 4-space rule is optional for continuation lines. ... (Also see the discussion of whether to...
Read more >
How to Write Beautiful Python Code With PEP 8 - Real Python
Learn how to write high-quality, readable code by using the Python style guidelines laid out in PEP 8. Following these guidelines helps you...
Read more >
What PEP 8 guidelines do you ignore, and which ones do you ...
PEP8 says to avoid "More than one space around an assignment (or ... PEP-8 explicitly says to break after a binary operator instead...
Read more >
An Overview of The PEP 8 Style Guide - Towards Data Science
PEP 8's aim is to bring all Python together under one styling guide. ... may need to break away from the style guide...
Read more >
Coding style - Django documentation
An exception to PEP 8 is our rules on line lengths. Don't limit lines of code to 79 characters if it means the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found