new-new-new Service worker not registering

After a choojs/bankai#new-new-new build, in which the app.use(require('choo-service-worker')()) is uncommented and set NODE_ENV=production, the service worker does not register.

I can confirm however that the bundle.js file built by bankai does have

navigator.serviceWorker.register

If I register the serviceWorker in the index.html, rather than bundle.js then the serviceWorker registers.

[goto-bus-stop]

the technical reason is that if no service worker file is found, bankai uses an empty Buffer instead as the input for the service worker node in the graph it uses to build things. But we could add a check in lib/cmd-build.js so that empty service worker files are not written

bankai looks for sw.js and service-worker.js files in your own source and uses whichever it finds first. If you want to use some service worker implementation from npm you can create a local service worker file that only requires the one from npm:

// sw.js
require('choo-service-worker/sw')

AFAIK the sw.js in choo-service-worker is only an example and not intended to be used in this way though

[sholtomaud]

Yep, that seems to work! Brilliant!

Probably need to update create-choo-app