Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Emit can't handle more than 1 parameter in views
See original GitHub issueExpected behavior
This code (view) should work
function someView (state, emit) {
return html`
<body>
<p>Send something through sockets:</p>
<input id="message" />
<button onclick=${onclick}>Send</button>
</body>
`
function onclick () {
emit('ws:send', document.getElementById('message').value, id)
document.getElementById('message').value = ''
}
}
Actual behavior
The id parameter in the ws:send event is undefined
Steps to reproduce behavior
Put that code in a view
This issue is only related to the way choo handle views, it is not related to nanobus. this can be checked running the same example in a store instead of a view, in the store, id is defined. This seems to be due to this code, here route handlers (views) are being called with a eventName and a single data parameter.
edit: I guess we could simply change this
var res = handler(self.state, function (eventName, data) {
self.emitter.emit(eventName, data)
})
to this
var res = handler(self.state, self.emitter.emit)
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (6 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
I’m not clear why it should support a single argument. Also, it’s not the way other event emitter work, e.g. Node EventEmitter
Maybe nanobus docs notation is unclear, it should be like
bus.emit(eventName, […data])
Fixed in
v6.6.1🎉