decodeURIComponent can throw at runtime

Hello! First of all, thank for this module, I love it.

I was testing a route and I mistyped the url, for instance instead of write 2 I wrote ", the result was that decodeURIComponent threw an URIError exception at runtime! I can easily fix this by using a try catch and return undefined, but it will deoptimize the function. We can also use a regex, something like:

if (/"/g.test(thisRoute)) return undefined

But actually I don’t know if " is the only bad character! Any suggestion? 😃

Thanks!

[yoshuawuyts]

Looks like introducing try/catch doesn’t introduce a huge performance regression and solves the issue. Could you open a PR for this?

On Fri, Apr 28, 2017, 19:18 Tomas Della Vedova [e-mail] wrote:

@davidmarkclements https://github.com/davidmarkclements use decodeURIComponent and escape together is not a good solution, since it introduces a wrong behaviour:

decodeURIComponent(escape(‘http://localhost:3030/test/cia%2Fo’))// => ‘http://localhost:3030/test/cia%2Fo’ decodeURIComponent(‘http://localhost:3030/test/cia%2Fo’)// => ‘http://localhost:3030/test/cia/o’

Probably the best solution is to use a try/catch

try { decodeURIComponent(‘http://localhost:3030/test/cia%2Fo’) } catch (e) { return undefined }

Here the benchmarks (in node v6.10.0) within and without the try/catch:

decodeURIComponent - no try/catch x 3,999,819 ops/sec ±0.79% (91 runs sampled) decodeURIComponent - try/catch x 3,842,394 ops/sec ±0.70% (93 runs sampled)

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/yoshuawuyts/wayfarer/issues/57#issuecomment-298056108, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWlerT25Idt2PHITxy8EICu98DOx8Xrks5r0h9egaJpZM4M13vC .

[delvedor]

@davidmarkclements use decodeURIComponent and escape together is not a good solution, since it introduces a wrong behaviour:

decodeURIComponent(escape('http://localhost:3030/test/cia%2Fo'))
// => 'http://localhost:3030/test/cia%2Fo'

decodeURIComponent('http://localhost:3030/test/cia%2Fo')
// => 'http://localhost:3030/test/cia/o'

Probably the best solution is to use a try/catch

try {
  decodeURIComponent('http://localhost:3030/test/cia%2Fo')
} catch (e) {
  return undefined
}

Here the benchmarks (in node v6.10.0) within and without the try/catch:

decodeURIComponent - no try/catch x 3,999,819 ops/sec ±0.79% (91 runs sampled)
decodeURIComponent - try/catch x 3,842,394 ops/sec ±0.70% (93 runs sampled)