question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

pnpm is not being detected by chromatic-cli

See original GitHub issue

Bug report

Our team has started using pnpm as our go-to package manager (npm compatibility with existing tooling + performance of yarn2 = win). We’re hitting a snag when using --patch-build. From what I can gather, that flag causes a call to installDependencies() which in turn is using yarn-or-npm to spawn the installation process.

Interestingly, the default seems to be yarn in our repo even though the README states that npm is the fallback.

It seems that our pipelines are able to publish to chromatic.com without issue, but I don’t know if the pnpm support that currently exists with chromatic-cli is intentional or incidental - filing as a bug made sense, but I could also see who this might be a feature request.

Issue Analytics

  • State:closed
  • Created 9 months ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
tmeasdaycommented, Dec 21, 2022

@wollardj the only reason chromatic needs a patch build is when there is no chromatic build for the merge base of the PR: https://www.chromatic.com/docs/branching-and-baselines#patch-builds

So a more manual solution looks something like:

  1. Run Chromatic for the last commit of the base branch (or push a new commit and do that)
  2. Merge the base branch into the head branch (or rebase)
  3. Run chromatic for the new head commit (merge or rebased).

The patch build feature is really just something to help folks get started with UI review before they have an existing set of builds on their repo.

0reactions
wollardjcommented, Dec 20, 2022

I’m reluctant to say it’s blocking us. Our primary blocker is time right now; time to look into work arounds. We are able to upload assets to Chromatic, but we’re not able to generate the original patch that Chromatic needs to expose change sets. We can certainly switch to npm or yarn, but then we’re back to our lack of time 😄

Read more comments on GitHub >

github_iconTop Results From Across the Web

pnpm command not recognized (VS Code) #4810
I've installed pnpm on Windows. The command works in Windows PowerShell Terminal, but I can't get it to work in VS Code PowerShell...
Read more >
Installation
If pnpm is broken and you cannot fix it by reinstalling, you might need to remove it manually from the PATH. ... Now...
Read more >
chromatic-cli - npm Package Health Analysis
The npm package chromatic-cli was scanned for known vulnerabilities and missing license, and no issues were found. Thus the package was deemed as...
Read more >
Automate Chromatic with GitHub Actions • Chromatic docs
forceRebuild, Do not skip build when a rebuild is detected. ... npm, pnpm run: yarn # Adds Chromatic as a step in the...
Read more >
pnpm - npm
To quote the Rush team: Microsoft uses pnpm in Rush repos with hundreds of projects and hundreds of PRs per day, and we've...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found