Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

When using `--skip`, also report github status `UI Review` with `UI Tests`

See original GitHub issue

We make use of the --skip to skip running Chromatic in our mono-repo when there are no UI changes. This follows the recommendation in monorepos#only-run-chromatic-when-changes-occur-in-a-subproject.

We’d like to enable github checks to enforce UX validation and review as a required github check on our main branch. I tried doing that by requiring both “UI Tests” and “UI Review”: Screen Shot 2021-05-26 at 5 57 16 PM

Unfortunately when skipped, Chromatic only reports UI Tests. The PR will wait endlessly for UI Review which is never reported.

Ask: when using --skip report both UI Review and UI Tests with status “Skipped build.”.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9 (7 by maintainers)

github_iconTop GitHub Comments

radfahrercommented, Jan 19, 2022

Thank you @tmeasday!

radfahrercommented, Dec 9, 2021

@tmeasday any timeline on when this fix will go out, or if we need to change anything to get it to work? We are still running into this issue.

Read more comments on GitHub >

github_iconTop Results From Across the Web

About status checks - GitHub Docs
To skip checks for a commit, type your commit message and a short, meaningful description of your changes. · To request checks for...
Read more >
Error on using skip in chromaui/action@v1 #309 - GitHub
I tried to avoid ui testing when the branch name matches the nostorybook/** pattern. So I used the skip option in the chromaui/action@v1...
Read more >
Report latest PR status when build is skipped with ``[skip ci]``
We are thinking that we might need to implement UI option to "never skip commits for PR". But I still cannot reproduce this...
Read more >
UI Review is not skipped when passing true to the skip flag #549
The problem is happening is this PR: Axedyson/syncbase#6 Would be nice if the skip flag when given the value true also would skip...
Read more >
Chromatic Action bug: `skip` doesn't always mark "UI Review ...
Bug report We are using skip in Chromatic's GH action. It works sometimes, but other times, it fails to mark "UI Review" as...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found