question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

takeUntil incorrectly placed

See original GitHub issue

Hello,

In the method _onTextAreaFound() the takeUntil must be the last operator in the pipe to correctly unsubscribe all observables:

                    takeUntil(this._destroyed$),
                    debounceTime(200),
                    distinctUntilChanged()

See https://blog.angularindepth.com/rxjs-avoiding-takeuntil-leaks-fb5182d047ef for the explanation.

Thanks for this great directive!

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
chrumcommented, Jun 4, 2019

ok, released the new version in the main channel https://github.com/chrum/ngx-autosize/releases/tag/1.6.2

1reaction
P3troniuscommented, Jun 3, 2019

Looks good! Works on the old chrome and latest as well. Thanks!

Read more comments on GitHub >

github_iconTop Results From Across the Web

RxJS: Avoiding takeUntil Leaks - ncjamieson
Let's look at the problem sequence and at the reason for the leaks. ... If the takeUntil operator is placed before an operator...
Read more >
Close subscription on condition with takeUntil() - Stack Overflow
I want to use takeUntil() to automatically close the subscription when is finally returns an array that has content:
Read more >
takeUntil will supercede chained calls, which means ... - GitHub
Major problem with this lib (?) - takeUntil will supercede chained calls, which means critical code may be skipped #2273.
Read more >
Can I use first() instead of takeUntil()? : r/Angular2 - Reddit
If I know that I'm going to fetch data from the server only once, should I even use takeUntil to unsubscribe? // This?...
Read more >
Best Practices for Managing RxJS Subscriptions - This Dot Labs
If we do not put some thought into how we manage and clean up the ... to prevent incorrect code from being executed,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found