Language order not respected correctly

It turns out that if you provide a header with language options,

e.g. curl -H 'Accept-Language: en-US,en;q=0.9,nl;q=0.8' wttr.in/~Portland

The system provides a response in the least-preferred language, e.g.:

Weerbericht voor: Portland

    \  /       Gedeeltelijk bewolkt
  _ /"".-.     59 °F
    \_(   ).   → 4 mph
    /(___(__)  9 mi
               0.0 in

This is incorrect. The first language in the list is the one that the site should choose for localization.

[drwilco]

Slight correction, the language with the highest q value should be chosen. (Which most browsers will make the first in the list, but it’s not mandatory.)

[marcopaganini]

The problem here seems to be that “en” has a somewhat of a “special status”: It’s the “default” language when no other language is specified, but not int he list of supported languages (SUPPORTED_LANGS). When “en” appears in the “Accept-Language” header, it is completely ignored by _find_supported_language().

This looks like a simple fix: Either add “en” to the list of supported languages (don’t know the side effects of it), or special case “en” in _find_supported_language().