Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

time format for JSON output

See original GitHub issue

hello,

when i use german language for JSON output, the time format is still in a format with AM and PM but in german or europe it is pretty uncommon to use that format, i expect a 24H format for time.

e.g.:

$ curl de.wttr.in/Berlin?format=j1
{
    "current_condition": [
        {
            "FeelsLikeC": "10",
            "FeelsLikeF": "50",
            "cloudcover": "0",
            "humidity": "76",
            "lang_de": [
                {
                    "value": "Regen"
                }
            ],
            "localObsDateTime": "2022-09-28 11:40 AM",
            "observation_time": "09:40 AM",
...
        {
            "astronomy": [
                {
                    "moon_illumination": "15",
                    "moon_phase": "Waxing Crescent",
                    "moonrise": "09:57 AM",
                    "moonset": "07:48 PM",
                    "sunrise": "07:02 AM",
                    "sunset": "06:51 PM"
                }
...

i would expect this format:

            "localObsDateTime": "2022-09-28 11:40",
            "observation_time": "09:40",
...
                    "moonrise": "09:57",
                    "moonset": "19:48",
                    "sunrise": "07:02",
                    "sunset": "18:51"
...

or is ther another way to select the time format?

Issue Analytics

State:
Created a year ago
Comments:8 (1 by maintainers)

Top GitHub Comments

1reaction

beta-testercommented, Oct 3, 2022

to have an option to choose between 12Hr and 24Hr time format would be nice.

0reactions

chubincommented, Oct 22, 2022

It is a good feature request. Accepted.

Should we make it configurable only with the time format parameter? Probably, the same parameter should be used in the one-line output format and everywhere else.

Also, we could make the date/time format fully configurable from outside (not only AM/PM, but just pass the format string).

If you would like to contribute, feel free to do it. The feature should be added here:

https://github.com/chubin/wttr.in/blob/master/lib/view/line.py#L388