Proposal: Remove 'focusedId' from computed 'days' as dependency

Hey, thanks for amazing work first of all.

I’m building an add-on for highlighting the current selection before user actually selecting it.

And stumbled upon re-computing days properties on each click, which actually happens with onFocusDay and onBlurDay events. From my opinion this looks inefficient and un-intuitive.

Would you be interested to just to update isFocused property for the corresponding day instead of re-computing days property? I can do PR.

e.g.

  _updateFocused(id, isFocused = true) {
    const day = this.get('days').findBy('id', id);
    day.set('isFocused', isFocused);
    this.set('focusedId', isFocused ? id : null);
  },

UPD: buildDay should return an Ember.Object at this case.

[cibernox]

It’s more the opposite. Why have ember objects if you don’t have to? I stick to POJOs as much as I can. Also with the plan to migrate the addon to glimmer as soon as they are interoperable.

[jozefvaclavik]

Just a quick sidenote. onfocus doens’t work in Safari and FF on OSX. Discovered it today the hard way.