Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support number skeleton

See original GitHub issue

I’m currently migrating one of my projects from svelte-i18n to svelte-intl-precompile and got the following error.

foo/locales/de-DE.json: Property value expected type of string but got object
TypeError: foo/locales/de-DE.json: Property value expected type of string but got object
    at Object.validate (foo/node_modules/@babel/types/lib/definitions/utils.js:159:13)
    at validateField (foo/node_modules/@babel/types/lib/validators/validate.js:24:9)
    at validate (foo/node_modules/@babel/types/lib/validators/validate.js:17:3)
    at String.builder (foo/node_modules/@babel/types/lib/builders/builder.js:39:27)
    at Object.stringLiteral (foo/node_modules/@babel/types/lib/builders/generated/index.js:357:27)
    at buildCallExpression (foo/node_modules/babel-plugin-precompile-intl/src/index.js:52:42)
    at buildTemplateLiteral (foo/node_modules/babel-plugin-precompile-intl/src/index.js:110:30)
    at buildFunction (foo/node_modules/babel-plugin-precompile-intl/src/index.js:160:67)
    at PluginPass.ObjectProperty (foo/node_modules/babel-plugin-precompile-intl/src/index.js:202:26)
    at newFn (foo/node_modules/@babel/traverse/lib/visitors.js:177:21)

After some digging I found out that the use of number skeletons (e.g Account balance {balance, number, ::currency/EUR}) is causing this error.

IMO the number skeletons are a very important part of the ICU Message Format and it would be nice if they where supported by svelte-intl-precompile

Issue Analytics

State:
Created a year ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

cibernoxcommented, May 3, 2022

Agreed. I must have missed that one as it’s one I haven’t used myself. I’m going to check https://unicode-org.github.io/icu/userguide/format_parse/numbers/skeletons.html and see if I can get an initial implementation by the end of the week. When I do I’ll ping you so you can test if works as you expect

0reactions

cibernoxcommented, May 30, 2022

Closing since this has been released in 0.10